⚠️ Deprecate metrics-bind-addr flag #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfariasalves-ionos
requested review from
piepmatz,
lubedacht,
mcbenjemaa and
wikkyk
as code owners
gfariasalves-ionos
changed the title
piepmatz
reviewed
Mar 14, 2024
|
Upgrading controller-runtime to v0.17.2 resolves the linting issues. |
# Conflicts: # go.mod # go.sum
piepmatz
requested changes
Mar 26, 2024
There was a problem hiding this comment.
- Don't forget updating the kustomize manifests:
--metrics-bind-addressis still in use there. And I'd really also go with--insecure-diagnosticsfor now. - However, we should at least provide the RBAC required for secure diagnostics:
// Add RBAC for the authorized diagnostics endpoint.
// +kubebuilder:rbac:groups=authentication.k8s.io,resources=tokenreviews,verbs=create
// +kubebuilder:rbac:groups=authorization.k8s.io,resources=subjectaccessreviews,verbs=create
lubedacht
reviewed
Apr 3, 2024
|
Seems like #70 (review) was forgotten? |
|
I did not, just forgot to push ;) |
So, maybe you wanna push now? |
piepmatz
requested changes
Apr 8, 2024
|
Have you tested the secured metrics port? So were you able to retrieve metrics after creating a role + binding and querying the port as the one the role was bound to? |
piepmatz
reviewed
Apr 12, 2024
|
Yes, I did. I tried exactly what was described in Cluster API documentation |
|
gfariasalves-ionos
changed the title
piepmatz
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request/Why do we need it?
See: https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.5-to-v1.6
See: kubernetes-sigs/cluster-api#9264
Checklist: