Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go to 1.22 #188

Merged
merged 1 commit into from
Aug 20, 2024
Merged

bump go to 1.22 #188

merged 1 commit into from
Aug 20, 2024

Conversation

wikkyk
Copy link
Collaborator

@wikkyk wikkyk commented Apr 25, 2024

Issue #, if available:
fix #187

+mass dep update:
k8s/api* to 0.30
controller-gen to 0.15.0 (0.14.0 has the go 1.22 panic fix)
controller-runtime to 0.18.0 (dependency)

Regenerated crds using new controller-gen. Note config/rbac/role.yaml and config/webhook/manifest.yaml.

@wikkyk
Copy link
Collaborator Author

wikkyk commented Apr 25, 2024

obsoletes #190

@wikkyk
Copy link
Collaborator Author

wikkyk commented Apr 25, 2024

#177

@wikkyk
Copy link
Collaborator Author

wikkyk commented Apr 25, 2024

I will squash this PR into a single commit because none of commits in the PR work without all the other commits in the PR.

@wikkyk
Copy link
Collaborator Author

wikkyk commented Jun 7, 2024

Rebased for v0.5.0.

Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcbenjemaa
Copy link
Member

We can rework this now.

@wikkyk
Copy link
Collaborator Author

wikkyk commented Aug 20, 2024

Ready for review.

go.mod Show resolved Hide resolved
@wikkyk
Copy link
Collaborator Author

wikkyk commented Aug 20, 2024

e2e passed, pushing cosmetic changes to go.mod

Plus relevant dependency updates.

fix #187
Copy link

sonarcloud bot commented Aug 20, 2024

Copy link
Member

@mcbenjemaa mcbenjemaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wikkyk wikkyk merged commit e585c6d into main Aug 20, 2024
7 of 9 checks passed
@wikkyk wikkyk deleted the go-1.22 branch August 20, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code go/1.22 requires go 1.22
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump go to 1.22
2 participants