Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: test improvements #398

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

workflows: test improvements #398

wants to merge 1 commit into from

Conversation

wikkyk
Copy link
Collaborator

@wikkyk wikkyk commented Jan 30, 2025

Issue #, if available:
Follow-up to #384 #390

Description of changes:
I converted the test workflows into a reusable workflow to reduce duplication.
I amended the comment message to also mention test runs requiring approval and reworded the comment text to make it terser.

Copy link

External PR

Test runs on external PRs require manual approval.

Note: This PR changes the following non-go, non-docs files:
.github/workflows/comment.yml
.github/workflows/e2e-comment.yml
.github/workflows/run-tests.yml
.github/workflows/test-comment.yml
.github/workflows/test-external.yml
.github/workflows/test.yml

Copy link

🚀 e2e tests run

We add labels to the PRs to control the e2e test runs by running specific tests and skipping some test contexts,
please follow this guide:

Label Behaviour
none Run Generic tests
e2e/none skip all e2e tests (documentation etc) - overrides all e2e/* labels Do not run any tests (overrides all e2e/ flags)
e2e/flatcar run Flatcar e2e tests Add Flatcar tests to the run

ℹ️ Ask a Member to add the requested labels if you don't have enough permissions.

Copy link

External PR

Test runs on external PRs require manual approval.

Note: This PR changes the following non-go, non-docs files:
.github/workflows/comment.yml
.github/workflows/e2e-comment.yml
.github/workflows/run-tests.yml
.github/workflows/test-comment.yml
.github/workflows/test-external.yml
.github/workflows/test.yml

Copy link

External PR

Test runs on external PRs require manual approval.

Note: This PR changes the following non-go, non-docs files:
.github/workflows/comment.yml
.github/workflows/e2e-comment.yml
.github/workflows/run-tests.yml
.github/workflows/test-comment.yml
.github/workflows/test-external.yml
.github/workflows/test.yml

@wikkyk wikkyk added the e2e/none skip all e2e tests (documentation etc) - overrides all e2e/* labels label Jan 30, 2025
@wikkyk wikkyk marked this pull request as draft January 30, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e/none skip all e2e tests (documentation etc) - overrides all e2e/* labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant