Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #452

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Update README.md #452

merged 1 commit into from
Jul 17, 2024

Conversation

hkacmaz
Copy link
Contributor

@hkacmaz hkacmaz commented Jul 9, 2024

--token $IONOS_TOKEN dollar sign is needed for exposed variable

@hkacmaz
Update README.md
df71912 
--token $IONOS_TOKEN dollar sign is needed for exposed variable
avirtopeanu-ionos
avirtopeanu-ionos approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@avirtopeanu-ionos avirtopeanu-ionos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sure we can change this to have a dollar sign

I think in its original state it was meant just to be a place-holder for the flag's value, but it doesn't hurt to show that you could use the IONOS_TOKEN env var here.

@avirtopeanu-ionos avirtopeanu-ionos merged commit 7f6f85a into ionos-cloud:master Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avirtopeanu-ionos avirtopeanu-ionos avirtopeanu-ionos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkacmaz @avirtopeanu-ionos