Remove recompose dependency #510
Conversation
…se wrapDisplayName method in packages/react-redux-subspace/src/utils/createDisplayname.js, replace recompose/wrapDisplayName with createDisplayname in packages/react-redux-subspace/src/components/parentSpaced.js and packages/react-redux-subspace/src/components/subspaced.js, remove recompse dependency in package.json
…o packages/react-redux-subspace/src/utils/createDisplayName.js, implement tests for packages/react-redux-subspace/src/utils/createDisplayName.js in packages/react-redux-subspace/test/utils/createDisplayname-spec.js
…ead of monorepo package.json
|
Hi @Byron-Wall, Sorry it's taken a while to get to this review. The changes itself is fine and I'm happy to accept it, but there is a lot of formatting changes that seem unnecessary for replacing a function (I understand that there are no formatting rules in place to help with that). I'll merge as-is, but please don't be offended if I add a prettier config and it all gets formatted back again. |
|
Hey, thanks for the review, Ive been out all week, so the timing has worked out well for me. I am in no way offended if a prettier config changes formatting. Thanks! |
|
Hey @mpeyper , would it be possible to let me know when you are able to publish this update to NPM? |
|
@Byron-Wall Yes, sorry. Plan was to do it yesterday, but had some production issues at work and swamped me. I'll endeavour to do it today. |
|
@Byron-Wall this has been released in |
|
@mpeyper thanks for releasing/letting me know! |
Adds createDisplayName util to react-redux-subspace, replaces recompose/wrapDisplayName in react-redux-subspace/src/components/parentSpaced.js and react-redux-subspace/src/components/subspaced.js, and adds test file for createDisplayName util. This removes the
recomposedependency, which is currently unmaintained and returning a denial-of-service security issue fromnpm audit