Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

#60 - Added Subspace logo #61

Closed
wants to merge 8 commits into from
Closed

#60 - Added Subspace logo #61

wants to merge 8 commits into from

Conversation

matthewhartman
Copy link

Let me know what you think.

I can do more tweaks to this current version or go down a different approach :)

@mpeyper
Copy link
Contributor

mpeyper commented Jan 7, 2018

My initial reaction was that I really liked it!

I made a few small notes:

  • Perhaps the loops could be different colours? IOOF dark green, IOOF light green and Redux purple?
  • 2 of the loops are open with 1 dot and the other is closed with 2 dots. Intentional?
  • Make the 'S' a bit bigger so it's more identifiable at favicon size

The more I looked at it, the more familiar it felt... Then it hit me... it's VERY similar to the React logo

image

It's actually a pretty nice mash up of the React and Redux logos and could almost be a good logo for the react-redux package.

image

image

I was sort of ok with the similarities, because as I said, I quite like the design, but then I stumbled across another popular library's logo when looking for links for this response... react-semantic and it's a bit too close for my liking.

image

image

So I like the direction of this, but I'm not sure what can be done to make it more unique from other packages?

@mpeyper mpeyper changed the title #60 - Added SubSpace logo #60 - Added Subspace logo Jan 7, 2018
@matthewhartman
Copy link
Author

matthewhartman commented Jan 7, 2018

Sorry for the late reply, I got a hall pass for a couple of hours ;)

I tried to mash up the react and redux logo into like an 'atom' and each circle would represent a 'store' and it's all connected, so each store is talking to another.

I still think it's quite different to the react-semantic package logo (this is the first time I'm seeing this logo).

I can add circles to where those missing gaps are so it's all connected up.

If you're not happy with it still, I can try for a different direction.

Looking forward to hearing your thoughts.

@mpeyper
Copy link
Contributor

mpeyper commented Jan 7, 2018

I think I'd like it less on the React path and more on the Redux path. By that I mean that redux-subspace is an extension of the redux ecosystem and it's only because their's touches React that we have to too.

each circle would represent a 'store' and it's all connected, so each store is talking to another

If we're trying to bring in conceptual tie-ins to the logo, then the store interaction is actually more about isolation and preventing cross-talk between the stores. Composition of subspaces (nesting stores in stores) is another area where a conceptual tie-in for a logo might be possible.

I still think it's quite different to the react-semantic package logo

I really liked it until I saw react-semantic's, and I can't un-see it now 😞

Sorry for the late reply, I got a hall pass for a couple of hours ;)

Lucky you!

@mpeyper
Copy link
Contributor

mpeyper commented Jan 7, 2018

If you're not happy with it

Also, I'd like to stress that this is not just my library. Anyone from IOOF can review and accept changes. I'm happy to be outvoted if others want it.

@matthewhartman
Copy link
Author

If each store is isolated, I'm thinking something more like a universe where you've got multiple planets or stars, which are independent to each other.

Let me have a think about it for some time and come up with another concept.

Cheers.

@matthewhartman
Copy link
Author

https://github.com/ioof-holdings/redux-subspace/blob/e83d89aa6fe7f678b44b224790f6f59f835c66c1/README.md

Those comets look a little out of whack. The colours might need tweaking too.

@matthewhartman
Copy link
Author

matthewhartman commented Jan 7, 2018

Check it out mate:
https://github.com/ioof-holdings/redux-subspace/blob/b326f6fc4dd6b838eb9d9fb6677d962ae4511d42/README.md

I think it's heading in the right direction. Might need a few more minor refinements, but I'm pretty happy with it :)

@jpeyper
Copy link
Collaborator

jpeyper commented Jan 7, 2018

That's looking awesome. I love it.

@mpeyper
Copy link
Contributor

mpeyper commented Jan 7, 2018

@matthewhartman and myself have been discussing this over slack (faster feedback than github issues), but I thought I should put a summary here for other to see:

  • we like the mix of "redux purple" and "ioof greens"
  • we're not sure on the grey-blue "comets"
    • mainly the colour is off, conceptually they are fine

This concept gave me an idea which I tried to make a quick mock up of:
screen shot 2018-01-07 at 7 54 52 pm

  • the rings are inspired the redux logo where it has been stretched out into a circle
    • the outer ring represents the root redux store ("redux purple"... get it!)
    • the inner rings represent nested subspaces (they look like stores but they're not - different colours!)
    • the layers don't cross, highlighting the isolation of the subspaces from one another
  • I like it with nothing in the middle, but would like to see versions with an 'S', or the redux logo (I think this one will look too busy)
  • lines should be same width and length, and evenly spaced
  • prefer the weight of the inner layer to the outer layer
  • play with rotation of layers to feel less symmetrical

If someone with more skills in making images want to tidy this up I'd love to see it. I do very much like @matthewhartman's direction, so don't think my mock up is the final word, just an idea I had.

@mpeyper
Copy link
Contributor

mpeyper commented Jun 28, 2018

I'm going to close this as it's been pretty stale for a while.

Happy to reopen if anyone wants to continue with it, or feel free to open a new PR (or just reply to #60 if you want to discuss ideas).

@mpeyper mpeyper closed this Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants