This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Pass saga args through to subspaced sagas #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeyper
commented
Jan 12, 2018
| @@ -43,113 +43,9 @@ describe('integration tests', () => { | |||
| } | |||
| } | |||
|
|
|||
| it('should transfer context to subspaced saga', () => { | |||
There was a problem hiding this comment.
I only moved the context tests down the file.
mpeyper
commented
Jan 12, 2018
| }) | ||
| }) | ||
|
|
||
| it('should pass args through to subspaced saga', () => { |
There was a problem hiding this comment.
This is where the new tests for passing args start
mpeyper
commented
Jan 12, 2018
| const provideStore = (store, options) => (saga) => { | ||
| return function* () { | ||
| yield setContext({ store }) | ||
| yield setContext({ sagaMiddlewareOptions: options }) |
There was a problem hiding this comment.
There was no reason to make seperate calls to setContext here.
|
Looks good to me :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redux-saga supports passing arguments to sagas when running them. Although
createSagaMiddlewaredoes pass the args on when to the underlyingruncall, thesubspacedandprovideStorehigher-order sagas would not pass them through to the sagas they were wrapping.