This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
middleware api now includes all subspace values so root enhancer can be applied in middleware #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be applied in middleware
|
This has been causing some absolute doozey bugs... Glad we found it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subspaceOptions (which has the root enhancer) was not being passed through to the middleware API. Any subspaces created in middleware were not correctly applying the middleware chain.
I felt it's safer to to exclude the parts of the subspacedStore we don't want, to avoid issues like this in the future (we have to be careful to remember to update the typescript definitions).