Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attempt at fixing tests #272

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Another attempt at fixing tests #272

merged 3 commits into from
Oct 14, 2022

Conversation

vinisalazar
Copy link
Contributor

Summary of changes

  - Switching tests to gold standard server (ioos#261)
  - Will rebase ioos#271 after merging
@@ -62,16 +62,16 @@ def dataset_opendap(neracoos):
@pytest.fixture
def dataset_tabledap(sensors):
"""Load tabledap for testing."""
sensors.dataset_id = "osmc_23091"
sensors.dataset_id = "org_cormp_cap2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Missed that and we should've probably had this in another PR to merge before trying to fix the macOS problem.

@@ -15,7 +15,7 @@
def sensors():
"""Instantiate ERDDAP class for testing."""
yield ERDDAP(
server="https://erddap.sensors.ioos.us/erddap/",
server="https://standards.sensors.ioos.us/erddap/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as https://github.com/ioos/erddapy/pull/272/files#r996095309, I ended up clobbering these changes b/c I wanted to separate the issues.

@ocefpaf
Copy link
Member

ocefpaf commented Oct 14, 2022

Things are passing now \o/

Sorry for clobbering some of your changes but my old brain needed some separation of contexts here to understand all the failures. And thanks for tackling yet another maintenance PR! Those can be tedious but are as important as new code.

@ocefpaf ocefpaf merged commit 3119ee2 into ioos:main Oct 14, 2022
@ocefpaf ocefpaf added the GSoC22 label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants