Use yarl to build URLs instead of string manipulations for more robust URL creation #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
force-pushed
the
yarl
branch
6 times, most recently
from
f5a08ad to
45374e7
Compare
ocefpaf
changed the title
ocefpaf
force-pushed
the
yarl
branch
2 times, most recently
from
b68ca14 to
10038d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to also return an
yarl.URLobject in the future but that will be a breaking change, so we'll convert them to strings for now. This should make our URLs more robust and get some nice human/quoted urls easily.Check what can be refactored/deleted from the ones below.