Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos #129

Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix some typos #129

merged 1 commit into from
Mar 9, 2023

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 8, 2023

We cannot run codespell cleanly on notebooks yet but we can do:

for nb in **/*.ipynb ; do echo "${nb}"; cat "${nb}" | jupytext --from ipynb --to py:percent | codespell -; done 2>&1 | tee log

to convert with jupytext and run on the result.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 8, 2023

@MathewBiddle I'm inclined to remove the reviewnb now that GH rolled out the notebook diffs. This one look gorgeous BTW

image

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 8, 2023

BTW, I cannot remove nbreview, not enough rights to the repo, but if you agree you can follow this to remove it:

Screenshot from 2023-03-08 14-06-54

@MathewBiddle
Copy link
Contributor

Review Notebook App uninstalled. Should be removed in a bit.

@ocefpaf ocefpaf merged commit 7f403a3 into ioos:main Mar 9, 2023
@ocefpaf ocefpaf deleted the typos branch March 9, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants