Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove archived notebooks from the published book #151

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Aug 30, 2023

@MathewBiddle I moved all the stale notebooks to "archived" so they don't get published anymore. Most of them are not worth revisiting but those that are, we still have the file in the repo as a starting point.

@MathewBiddle
Copy link
Contributor

ah. Changed the extension, nice. When merged, we should check that the chapter table of contents reflect the change. For example, https://ioos.github.io/ioos_code_lab/content/code_gallery/data_access.html

@MathewBiddle
Copy link
Contributor

@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 30, 2023

it would be nice if you could view those notebooks in the web interface

jupyterbook probably has something to ignore some notebooks in some list... Let me check if that exists before we merge this one so we don't need to rename them.

@ocefpaf ocefpaf requested a review from MathewBiddle August 30, 2023 21:22
@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 30, 2023

This one should be ready to go. I'll fix the pre-commits and failing notebooks in #152 to avoid conflicts. Most of the failing notebooks are ERDDAP server failures that may require replacement.

@MathewBiddle
Copy link
Contributor

Built the book locally and everything seemed to work as expected. TOC for chapter headers were automatically updated as well. Thanks for addressing this so quickly.

@MathewBiddle MathewBiddle merged commit a615c54 into ioos:main Aug 31, 2023
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ocefpaf ocefpaf deleted the archive_stale_notebooks branch August 31, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants