-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the ERDDAP server instead or pyoos #88
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@MathewBiddle this one is ready for review. I removed the QA/QC part b/c that no longer makes sense. The data was corrected in the server and the cleanup step we had here is no longer necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some adjustments to the narrative and added a map plot of the bounding box, just to set the scene a little more.
I was trying to figure out where that stationsXml opendap link came from and I can't trace it back. Could you add something to that section describing where you got it?
Also, it would be nice to show the ERDDAP request that fails as you describe in the beginning. Is there anyway we could show how it fails and what we have to do to work around it? This could be a nice example of how ERDDAP admins could make things difficult for users.
👍
That one was not easy to find. After multiple failed attempts I found a link in the metadata for I'll add a cell that prints the STATION_ID metadata and some text to explain how to get the xml from it.
It fails silently if we add TL;DR I'd rather put another notebook where we can show the problem to the data providers instead of adding many extra steps here just to show a failed attempt to users. I believe users should never see that and, IMO, that server is kind of broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needed to update the title SOS -> ERDDAP
Looks good to merge!
Thank you for send a Pull Request to our code gallery! When adding or updating a notebook please check if:
Created: YYYY-MM-DD
in the first cell.Updated: YYYY-MM-DD
below the created date.Closes #46
@MathewBiddle note that I read the station info from the XML using some xpath tricks.That really defeats the purpose of having that data in ERDDAP b/c one cannot filter using just ERDDAP and some extra Knowledge of the data is requires before hand . I'm not sure why that server is set up the way it is, looks like some metadata may be missing or the original data format is not ideal*. It is still better than
pyoos
and the old SOS.* I would get rid of
BEGIN_DATE
andEND_DATE
variables, thetime
variable should be enough. I would also changeSTATION_ID
from a variable to adataset_id
. The currentdataset_id
s are what should be variables, likeWater Level - Verified Six Minute
.