Add @iopipe/event-info.eventType for all key events (#263)

Closes #262
iopipe · Sep 25, 2018 · a6120ff · a6120ff
1 parent ed3c22c
commit a6120ff
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/iopipe/contrib/eventinfo/event_types.py b/iopipe/contrib/eventinfo/event_types.py
@@ -19,9 +19,12 @@ def has_required_keys(self):
 
     def collect(self):
         if self.keys == "all":
-            return collect_all_keys(
+            event_info = collect_all_keys(
                 self.event, "@iopipe/event-info.%s" % self.type, self.exclude_keys
             )
+            event_info["@iopipe/event-info.eventType"] = self.type
+            return event_info
+
         event_info = {}
         for key in self.keys:
             if isinstance(key, tuple):

diff --git a/tests/contrib/eventinfo/test_event_types.py b/tests/contrib/eventinfo/test_event_types.py
@@ -7,9 +7,12 @@ def test__event_types__alexa_skill(event_alexa_skill):
     assert event.has_required_keys() is True
 
     event_info = event.collect()
-    assert event_info != {}
-    assert all([k.startswith("@iopipe/event-info.alexaSkill.") for k in event_info])
-    assert len(list(event_info.keys())) == 31
+    expected_keys = ["@iopipe/event-info.eventType"] + [
+        "@iopipe/event-info.alexaSkill.%s" % key for key in event.keys
+    ]
+    assert list(event_info.keys()).sort() == expected_keys.sort()
+
+    assert len(list(event_info.keys())) == 32
 
 
 def test__event_types__apigw(event_apigw):