Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sns event type casing #251

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Fix sns event type casing #251

merged 1 commit into from
Jul 13, 2018

Conversation

kolanos
Copy link
Contributor

@kolanos kolanos commented Jul 13, 2018

Closes #250

Signed-off-by: Michael Lavers kolanos@gmail.com

@kolanos kolanos requested a review from XerTheSquirrel July 13, 2018 18:09
@kolanos kolanos self-assigned this Jul 13, 2018
Closes iopipe#250

Signed-off-by: Michael Lavers <kolanos@gmail.com>
@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files          33       33           
  Lines        1017     1017           
=======================================
  Hits          846      846           
  Misses        171      171
Impacted Files Coverage Δ
iopipe/contrib/eventinfo/event_types.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684c3c1...91ed662. Read the comment docs.

Copy link

@XerTheSquirrel XerTheSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kolanos kolanos merged commit e96570b into iopipe:master Jul 13, 2018
@kolanos kolanos deleted the issue/250 branch July 13, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants