Ensure that bytes/str values are decoded to utf-8 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuinnyPig
reviewed
Aug 15, 2018
iopipe/contrib/trace/util.py
Outdated
|
|
||
|
|
||
| def ensure_utf8(v): | ||
| """Ensures that a binary value is dedoced into utf-8""" |
pselle
reviewed
Aug 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 83.37% 83.62% +0.25%
==========================================
Files 34 34
Lines 1125 1124 -1
==========================================
+ Hits 938 940 +2
+ Misses 187 184 -3
Continue to review full report at Codecov.
|
iopipe/contrib/trace/auto_http.py
Outdated
| @@ -139,36 +140,36 @@ def collect_metrics_for_response(http_response, context, trace, http_filter): | |||
| request_headers = [] | |||
| if hasattr(http_response.request, "headers"): | |||
| request_headers = [ | |||
| {"key": k, "string": v} | |||
| {"key": k, "string": ensure_utf8(v)} | |||
There was a problem hiding this comment.
Should the key for the headers also have their UTF-8 ensured?
iopipe/contrib/trace/auto_http.py
Outdated
| ) | ||
|
|
||
| response_headers = [] | ||
| if hasattr(http_response, "headers"): | ||
| response_headers = [ | ||
| {"key": k, "string": v} | ||
| {"key": k, "string": ensure_utf8(v)} |
There was a problem hiding this comment.
Should the response header key also have UTF-8 ensured?
pselle
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259