Add network timeout config to signer/upload requests #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pselle
reviewed
Oct 18, 2018
| """ | ||
| try: | ||
| logger.debug("Uploading log data to IOpipe") | ||
| if isinstance(stream_or_file, StringIO): | ||
| stream_or_file.seek(0) | ||
| response = requests.put(url, data=stream_or_file, timeout=None) | ||
| response = requests.put( | ||
| url, data=stream_or_file, timeout=config["network_timeout"] |
There was a problem hiding this comment.
Hmm, do we want to use the same network timeout as collector? Or have it be a separate config item? The default value for this is 5000ms and I think we can be much more aggressive with the signer API (100ms)
There was a problem hiding this comment.
(honestly, could be that we should make that 5000 much smaller)
There was a problem hiding this comment.
I don't think the service characteristics of the collector and signer are different enough to warrant a significantly different timeout. If both services are healthy these timeouts should never be hit. The timeout acts as a n upper bound, or worst case, so would be conservative here. I'm not even sure 5s is going to be enough for S3 uploads.
pselle
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #266