Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monkey patching for botocore.httpsession #321

Merged
merged 5 commits into from
Jun 6, 2019

Conversation

kolanos
Copy link
Contributor

@kolanos kolanos commented Jun 6, 2019

Closes #319

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #321 into master will decrease coverage by 0.52%.
The diff coverage is 69.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   83.47%   82.95%   -0.53%     
==========================================
  Files          36       36              
  Lines        1283     1320      +37     
==========================================
+ Hits         1071     1095      +24     
- Misses        212      225      +13
Impacted Files Coverage Δ
iopipe/contrib/trace/auto_http.py 76.1% <69.81%> (-5.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f74d6c...b207b91. Read the comment docs.

@kolanos kolanos self-assigned this Jun 6, 2019
@mrickard
Copy link

mrickard commented Jun 6, 2019

It looks like this one's consistently failing on the python 2.7 build. I'm not quite sure where that's failing, exactly...but this seems like something we should correct before we remove support for it.

@kolanos
Copy link
Contributor Author

kolanos commented Jun 6, 2019

@mrickard The python2.7 issue is fixed. The code coverage will be tricky as I'd need to monkey patch a monkey patch to properly mock that, will require further investigation as to the best method to do that. Only a minor drop in code coverage for now.

Copy link

@mrickard mrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @kolanos That's definitely tricky. Very meta. Thanks!

@kolanos kolanos merged commit 43828d5 into iopipe:master Jun 6, 2019
@kolanos kolanos deleted the issue/319 branch June 6, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boto3 requests not being auto traced in 3.7
2 participants