Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit HTTP headers collected, allow overide #326

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Conversation

kolanos
Copy link
Contributor

@kolanos kolanos commented Jun 8, 2019

Closes #274 #305

@kolanos kolanos self-assigned this Jun 8, 2019
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #326 into master will decrease coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   83.21%   83.19%   -0.03%     
==========================================
  Files          36       36              
  Lines        1317     1321       +4     
==========================================
+ Hits         1096     1099       +3     
- Misses        221      222       +1
Impacted Files Coverage Δ
iopipe/contrib/trace/plugin.py 100% <100%> (ø) ⬆️
iopipe/contrib/trace/auto_http.py 76.52% <84.61%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c1898...7d9445c. Read the comment docs.

@kolanos kolanos requested a review from javonharper June 10, 2019 17:16
@@ -423,6 +423,16 @@ def http_filter(request, response):
iopipe = IOpipe(plugins=[TracePlugin(auto_http=True, http_filter=http_filter)])
```

To add additional HTTP headers to your ttrace data use `http_headers`:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo with ttrace. (As someone with the occasional MBP stuck-key issue...solidarity.)

Copy link

@mrickard mrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kolanos kolanos merged commit 093f1e5 into iopipe:master Jun 11, 2019
@kolanos kolanos deleted the issue/274 branch June 11, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit http trace headers, allow override
2 participants