-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kagi.ts search-engine #483
Conversation
HOLY MOLY! This was unexpected haha! |
First off, thank you for you contribution! It's always cool to see when someone dives into a codebase lacking documentation, figures things out and makes a contribution anyways. General ThoughtsI didn't know that Kagi was a thing. The concept of a paid search engine sounds really interesting to me. (But that's beside the point.) I've tested this PR and things seem to be working nicely when it comes to blocking regular search results: kagi-demo.webmBut I was not able to get the ublacklist/src/scripts/search-engines/kagi.ts Lines 19 to 21 in a663ffa
This leads to a genuine question that I have in mind when it comes to adding support to this search engine. Generally speaking, the process of debugging the behavior of uBlacklist involves reproducing a search query on your local machine, opening up Browser Developer Tools and inspecting the DOM. But since Kagi is a paid service and I don't have a subscription (I'll assume iorate doesn't have one well), this could lead to us being unable to solve a bug report on our own. Would you/someone from Kagi be willing to work on user submitted bug reports, if some issue arrises? (e.g. a change to Kagi's layout that broke the position of a Kagi Supports Blocking WebsitesIt seems that Kagi already has some interesting functionality when it comes to blocking results. Here's an excerpt from the main page:
Although, I can see the value of using uBlacklist with it, since there are other cool things provided by the extension, such as blocking results with regular expressions, highlighting them, etc. I'm only mentioning this to know if you have an opinion about it. AfterthoughtsAnyways, it's mostly up to iorate to decide things here, and nothing of what I said before is intended to invalidate the work on this PR. I think it could be a cool thing if done properly. |
Thank you for the excellent suggestion regarding the example page (I forgot about that page). On the actual search page
We have a Trial plan with 100 free searches (https://kagi.com/onboarding?p=choose_plan).
Of course.
This addition was based on a user suggestion to incorporate |
Oh, that's actually pretty cool. I will try it later.
I see, it makes more sense now. |
Thank you for your contribution. |
Thanks to @GeorgeIsInTheAir and @iorate. I'm really glad that I hope for Kagi forum and here. |
🎉 This PR is included in version 8.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi all, could someone clarify if this is already, or when it will be, available in the uBlacklist iOS/iPadOS app for Safari Thank you! |
One More Thing... |
@GeorgeIsInTheAir GeorgeIsInTheAir It doesn't seem to be working. uBlacklist for Safari 8.8.2 with Safari 17.5 (19618.2.12.11.6) on macOS Sonoma.5 Even if it works with Orion, it may not work with Safari. |
@aug-dev Thanks guide.
uBlacklist 8.8.1 on Orion Browser by Kagi 0.99 on macOS Sonoma.5 is working and no problem. |
This PR adds Kagi search engine support.