Fix Large Incremental Installs #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reInstallApplicationBundle. This version does not seem to need it and it appears this causes errors during long install operations where the session will timeout and reult in kAMDSendMessageError. The standard install method will fail without the start session call. Information about AMDevice session behavior was gleaned from https://github.com/facebook/idb/blob/8172962dd871805127ad883ce99e75ae0f7bea44/FBDeviceControl/Management/FBAMDevice.h.
gabebear
requested changes
Aug 19, 2020
…for incremental installs.
ivanhernandez13
force-pushed
the
master
branch
from
107b4cb
to
54c0a6b
Compare
gabebear
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large apps installed with the incremental flag will timeout in one minute if done when a session is running. Timeouts are common for the initial install of large apps done with the incremental flag.
Remove start/stop/disconnect session calls from calls to AMDeviceSecureInstallApplicationBundle. This version does not seem to need it and it appears this causes errors during long install operations where the session will timeout and reult in kAMDSendMessageError. The standard install method will fail without the start session call.
Information about AMDevice session behavior was gleaned from https://github.com/facebook/idb/blob/8172962dd871805127ad883ce99e75ae0f7bea44/FBDeviceControl/Management/FBAMDevice.h.