Print the installation path of the app bundle on the actual device af… #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter installation. Prints by default when using JSON output because new JSON fields are presumably backwards compatible and will be ignored by any existing parsing logic. Requires --verbose when not using JSON to maintain formaat of existing output.
gabebear
reviewed
Feb 17, 2021
| if (bundle_id != NULL) { | ||
| install_bundle_id = CFStringCreateWithCString(NULL, bundle_id, kCFStringEncodingUTF8); | ||
| } else { | ||
| CFStringRef extracted_bundle_id = copy_bundle_id(url); |
There was a problem hiding this comment.
NVM, see below it will be released... have you run the analyzer on this change?
There was a problem hiding this comment.
Yep did run analyzer, no new issues reported.
gabebear
approved these changes
Feb 17, 2021
ivanhernandez13
added a commit
to ivanhernandez13/ios-deploy
that referenced
this pull request
Dec 6, 2022
…quires explicitly providing a bundle id. The bundle id is used to determine the final install location so it can be printed but is not otherwise required.
ivanhernandez13
added a commit
that referenced
this pull request
Dec 8, 2022
…icitly providing a bundle id. The bundle id is used to determine the final install location so it can be printed but is not otherwise required. (#569)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ter installation. Prints by default when using JSON output because new JSON fields are presumably backwards compatible and will be ignored by any existing parsing logic. Requires --verbose when not using JSON to maintain formaat of existing output.