Speed up copy_find_path by specifying maxdepth in find #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabebear
requested changes
Jul 19, 2021
gabebear
requested changes
Jul 19, 2021
nisargjhaveri
force-pushed
the
copy_find_path_speed
branch
from
344ce7b
to
71de86c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, getting path for Symbols or DeveloperDiskImage.dmg took too long (~5-10 seconds) due to inefficient use of find command.
This PR attempts to fix that by limiting find in copy_find_path to specific max depth. The max depth is calculated crudely by simply counting number of forward slashes in the pattern. This brings down the time in my particular case from ~6 seconds to ~0 seconds.