Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese support #220

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

WesleyBatista
Copy link

Description of change

Add Portuguese support by bringing the official wordlist from bitcoin/bips repo, through src/keys/bip39.pt.rs and duplicating necessary portions of the codebase

  • tests/test_vectors/bip39/trezorPT.sh is an adapted copy of trezor.sh in same directory, main difference being the hash in line 15
  • tests/fixtures/bip39_pt.rs was generated with output from trezorPT.sh

Links to any relevant issues

Related: #219

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

cargo test --features=bip39-pt

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant