Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ed25519 tests #53

Closed
wants to merge 2 commits into from
Closed

Ed25519 tests #53

wants to merge 2 commits into from

Conversation

melatron
Copy link
Contributor

Description of change

  • Added Malleability test case.
  • Added zip215 tests.
  • Added ed25519 sign.input tests.
  • Removed TODO that is not needed.
  • Fixes issue Ed25519: Improve tests #19

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

All existing and new tests pass.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@melatron
Added tests for ed25519
c3b19c1 
* Added Malleability test case.
* Added zip215 tests.
* Added ed25519 sign.input tests.
* Removed TODO that is not needed.
@melatron
Fixed formatting
5f9edc7
@Wollac
Copy link
Contributor

Wollac commented Feb 17, 2021

Does it make sense to still leave tests in src/ed25519.rs or should they also be moved to tests?

Honestly, I am not sure whether we even still need those tests at all: We now have test_golden which tests the same parameters, contains more tests and is even the official reference.
@melatron what do you think?

@melatron melatron closed this Feb 17, 2021
@melatron melatron mentioned this pull request Feb 17, 2021
Merged
7 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semenov-vladyslav semenov-vladyslav Awaiting requested review from semenov-vladyslav semenov-vladyslav is a code owner

@Wollac Wollac Awaiting requested review from Wollac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melatron @Wollac