Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update deposit address to selected created explicit account #7907

Merged
merged 41 commits into from
Jan 22, 2024
Merged

feat: update deposit address to selected created explicit account #7907

merged 41 commits into from
Jan 22, 2024

Conversation

evavirseda
Copy link
Collaborator

@evavirseda evavirseda commented Jan 18, 2024 •
edited
Loading

Summary

Closes #7846

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

evavirseda and others added 30 commits December 22, 2023 17:09
@evavirseda
feat: add account to routes
e7fb493
@evavirseda
feat: add to analytics featureflag
f59e885
@evavirseda
fix: update naming
0705215
@cpl121
feat: update wallet state to accomodate accounts
3751426
@cpl121
Merge branches 'feat/update-wallet-state-to-accomodate-accounts' and …
ee32362 
…'feat/add-implicit-account-router' of github.com:iotaledger/firefly into feat/update-wallet-state-to-accomodate-accounts
@cpl121
feat: update events to accomodate accounts WIP
5af0ce7
@cpl121
feat: improve validate wallet api event
8010874
@cpl121
feat: improve imports
1533ab0
@cpl121
Merge branches 'feat/update-wallet-state-to-accomodate-accounts' and …
2603f28 
…'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-wallet-state-to-accomodate-accounts
@cpl121
fix merge
36a0c8d
@cpl121
feat: remove duplicate implicitAccountCreationRouter
f6aedaf
@cpl121
perf: update todo comment for getDepositAddress function
81edbf1
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'feat/…
55b2d8e 
…update-wallet-state-to-accomodate-accounts' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
feat: update dashboard to route to dashboard or implicit flow based o…
a4aaf36 
…n wallet status
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'feat/…
7f31e15 
…update-wallet-state-to-accomodate-accounts' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
feat: update event to walletEvent
9d4c85b
@cpl121
Merge branches 'feat/update-wallet-state-to-accomodate-accounts' and …
ed67128 
…'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-wallet-state-to-accomodate-accounts
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'feat/…
95b7648 
…update-wallet-state-to-accomodate-accounts' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
feat: update subscribeToWalletApiEventsForActiveProfile with new Wall…
7469703 
…etEvent
@cpl121
Merge branches 'feat/update-wallet-state-to-accomodate-accounts' and …
270303c 
…'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-wallet-state-to-accomodate-accounts
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'feat/…
129b81f 
…update-wallet-state-to-accomodate-accounts' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
fix: move onDestroy to the last view of implicit account creation
4ca6d8b
@cpl121
Merge branches 'feat/update-wallet-state-to-accomodate-accounts' and …
ea7bba0 
…'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-wallet-state-to-accomodate-accounts
@cpl121
Merge branch 'feat/update-wallet-state-to-accomodate-accounts' of git…
8cce33b 
…hub.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
perf: hasAccount reactive
91b03f4
@cpl121
perf: rename accountsOutput and implicitAccountsOutput
b618966
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'feat/…
28e035b 
…update-wallet-state-to-accomodate-accounts' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
fix: undo unsubscribeFromWalletApiEvents place
ce2d047
@cpl121
perf: add implicit account logic to handleNewOutputEventInternal
e7c5da1
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'devel…
385d62c 
…op-iota2.0' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@evavirseda evavirseda marked this pull request as ready for review January 19, 2024 12:23
cpl121
cpl121 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Base automatically changed from feat/update-events-to-accomodate-accounts to develop-iota2.0 January 19, 2024 16:21
@evavirseda
Merge branch 'develop-iota2.0' into feat/update-deposit-address-to-se…
21a0a7d 
…lected-created-explicit-account

packages/shared/lib/core/wallet/actions/events-handlers/handleNewOutputEvent.ts
@evavirseda
fix: remove duplicated code
1fa3c5b
@evavirseda evavirseda linked an issue Jan 22, 2024 that may be closed by this pull request
[Task]: Update deposit address to selected created explicit account #7846
Closed
begonaalvarezd
begonaalvarezd requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼 little thing

packages/shared/lib/core/wallet/actions/buildWalletState.ts Outdated Show resolved Hide resolved
@begonaalvarezd begonaalvarezd merged commit 61c6634 into develop-iota2.0 Jan 22, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/update-deposit-address-to-selected-created-explicit-account branch January 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Update deposit address to selected created explicit account
3 participants
@evavirseda @begonaalvarezd @cpl121