Critical objectstorage fix, Storable.ImportStorable, ShrinkingMap.Set return value and more #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/storable-import
karimodm
changed the title
…into feat/storable-import
karimodm
changed the title
muXxer
approved these changes
Jan 10, 2023
| @@ -68,12 +68,12 @@ func New[K comparable, V any](opts ...Option) *ShrinkingMap[K, V] { | |||
| return shrinkingMap | |||
| } | |||
|
|
|||
| // Set adds a key-value pair to the map. It returns true if the key exists. | |||
| func (s *ShrinkingMap[K, V]) Set(key K, value V) (updated bool) { | |||
There was a problem hiding this comment.
This changed the logic completely 😱
We use the shrining map also in other projects....
There was a problem hiding this comment.
OK, I checked all projects I know. We don't use the return value by now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Storablemodel initializeable from another model.updatedstatus of an object; the value should be constrained tocomparable. Return if the entry was instead created, regarded of its value update.GetandSetbase values instead of pointers to such values. This aids the storage of basic types.WithRealmin favor ofWithExtendedRealmto avoid potential prefix clashes.