Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Use Milestones for ordering DID Messages #480

Closed
2 tasks
JelleMillenaar opened this issue Nov 5, 2021 · 0 comments · Fixed by #506
Closed
2 tasks

[Task] Use Milestones for ordering DID Messages #480

JelleMillenaar opened this issue Nov 5, 2021 · 0 comments · Fixed by #506
Assignees
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Bug Something isn't working.

Comments

@JelleMillenaar
Copy link
Collaborator

Description

As described in the iota DID Method Specification, message ordering happens if two or more messages try to take the same place in the state machine. The ordering is meant to make use of the milestones of the IOTA network, but this is not yet implemented. In addition, we received a report that ordering based on the hash (after milestones), wasn't done according to how it is described in the method spec, that needs to be checked.

Motivation

Have deterministic ordering that cannot be changed after a DID message has been confirmed in the network.

To-do list

Create a task-specific to-do list . Please link PRs that match the To-do list item behind the item after it has been submitted.

  • Add milestone checking to the ordering mechanism
  • Check hashing based ordering to match the spec
@JelleMillenaar JelleMillenaar added the Bug Something isn't working. label Nov 5, 2021
@JelleMillenaar JelleMillenaar changed the title [Task] Uses Milestones for ordering DID Messages [Task] Use Milestones for ordering DID Messages Nov 8, 2021
@cycraig cycraig added the Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog label Nov 9, 2021
@abdulmth abdulmth linked a pull request Nov 23, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants