Deterministic ordering of competing messages #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
added
Bug
2 tasks
cycraig
approved these changes
Nov 24, 2021
olivereanderson
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
Looks mostly good to me. I agree with what @cycraig said regarding MilestoneError though.
olivereanderson
approved these changes
Nov 29, 2021
abdulmth
added
the
Rust
cycraig
added
the
Wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Ordering message now is implemented according to the specs, namely:
If two or more root documents, integration documents or diff documents compete in the chain. Eg. 2 integration message have the same
previous_message_idthey will be sorted according to the milestone that references them. If both messages have the same milestone, they will be alphabetically ordered according based on theirMessageId.Note: Milestone ordering only happens if two or more message compete in the chain!
Links to any relevant issues
fixes issue #480
Type of change