Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MixedResolver to Resolver in Wasm #1026

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

olivereanderson
Copy link
Contributor

Description of change

Renames MixedResolver to Resolver in the Wasm bindings. Also simplifies some internal logic used in the CredentialValidator (by taking advantage of bool::then_some released in Rust 1.62).

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

All tests pass locally

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@olivereanderson olivereanderson added Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Sep 16, 2022
@olivereanderson olivereanderson self-assigned this Sep 16, 2022
@olivereanderson olivereanderson added this to the v0.7 Features milestone Sep 16, 2022
@olivereanderson olivereanderson merged commit 747e549 into dev Sep 16, 2022
@olivereanderson olivereanderson deleted the chore/rename-mixed-resolver branch September 16, 2022 12:24
@PhilippGackstatter PhilippGackstatter changed the title Chore/rename mixed resolver Rename MixedResolver to Resolver in Wasm Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants