Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to iota-client 2.0.1-rc.4 and iota-client-wasm 0.5.0-alpha.6 #1088

Merged
merged 35 commits into from
Nov 24, 2022

Conversation

olivereanderson
Copy link
Contributor

@olivereanderson olivereanderson commented Nov 21, 2022

Description of change

For the Rust library:

  • Updates iota-client dependency to version 2.0.1-rc.4 which enables building the Rust library without pinning iota-types to a fixed older version.
  • The IotaIdentityClient trait has been simplified.
  • The IotaIdentityClientExt now contains some additional methods that are implemented in terms of IotaIdentityClient::get_protocol_parameters which were previously standalone methods on IotaIdentityClient.

For the JS bindings:

  • Updates the dependency on @iota/iota-client-wasm to 0.5.0-alpha.6 which changes the interface to the client somewhat. In particular one can now obtain a Client using a normal constructor (i.e. async Client.new is no longer necessary).
  • Simplifies the IIotaIdentityClient interface.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Examples run locally.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@olivereanderson olivereanderson self-assigned this Nov 23, 2022
@olivereanderson olivereanderson added Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog labels Nov 23, 2022
@olivereanderson olivereanderson added this to the v0.7 Features milestone Nov 23, 2022
@olivereanderson olivereanderson marked this pull request as ready for review November 23, 2022 13:15
@olivereanderson olivereanderson changed the title WIP: integrate latest iota client integrate iota-client 2.0.1-rc.4 Nov 23, 2022
@olivereanderson olivereanderson changed the title integrate iota-client 2.0.1-rc.4 Integrate iota-client 2.0.1-rc.4 and iota-client-wasm 0.5.0-alpha.6 Nov 23, 2022
@olivereanderson olivereanderson changed the title Integrate iota-client 2.0.1-rc.4 and iota-client-wasm 0.5.0-alpha.6 Update to iota-client 2.0.1-rc.4 and iota-client-wasm 0.5.0-alpha.6 Nov 23, 2022
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@olivereanderson olivereanderson merged commit c251d90 into main Nov 24, 2022
@olivereanderson olivereanderson deleted the origin/integrate-latest-iota-client-bindings branch November 24, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

Successfully merging this pull request may close these issues.

3 participants