-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to iota-client
2.0.1-rc.4 and iota-client-wasm
0.5.0-alpha.6
#1088
Merged
olivereanderson
merged 35 commits into
main
from
origin/integrate-latest-iota-client-bindings
Nov 24, 2022
Merged
Update to iota-client
2.0.1-rc.4 and iota-client-wasm
0.5.0-alpha.6
#1088
olivereanderson
merged 35 commits into
main
from
origin/integrate-latest-iota-client-bindings
Nov 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-iota-client-bindings
olivereanderson
added
Breaking change
A change to the API that requires a major release. Part of "Changed" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
labels
Nov 23, 2022
olivereanderson
changed the title
WIP: integrate latest iota client
integrate iota-client 2.0.1-rc.4
Nov 23, 2022
eike-hass
reviewed
Nov 23, 2022
olivereanderson
changed the title
integrate iota-client 2.0.1-rc.4
Integrate Nov 23, 2022
iota-client
2.0.1-rc.4 and iota-client-wasm
0.5.0-alpha.6
eike-hass
approved these changes
Nov 23, 2022
olivereanderson
changed the title
Integrate
Update to Nov 23, 2022
iota-client
2.0.1-rc.4 and iota-client-wasm
0.5.0-alpha.6iota-client
2.0.1-rc.4 and iota-client-wasm
0.5.0-alpha.6
PhilippGackstatter
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
olivereanderson
deleted the
origin/integrate-latest-iota-client-bindings
branch
November 24, 2022 09:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking change
A change to the API that requires a major release. Part of "Changed" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
For the Rust library:
iota-client
dependency to version2.0.1-rc.4
which enables building the Rust library without pinningiota-types
to a fixed older version.IotaIdentityClient
trait has been simplified.IotaIdentityClientExt
now contains some additional methods that are implemented in terms ofIotaIdentityClient::get_protocol_parameters
which were previously standalone methods onIotaIdentityClient
.For the JS bindings:
@iota/iota-client-wasm
to0.5.0-alpha.6
which changes the interface to the client somewhat. In particular one can now obtain aClient
using a normal constructor (i.e.async Client.new
is no longer necessary).IIotaIdentityClient
interface.Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Examples run locally.
Change checklist
Add an
x
to the boxes that are relevant to your changes.