Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish identity_iota_core #1203

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Conversation

PhilippGackstatter
Copy link
Contributor

Description of change

Polish identity_iota_core by unifying method signatures across IotaDocument and CoreDocument, removing unused error variants, renaming tag to tag_str to be in line with network_str and making the properties field of IotaDocumentMetadata private so we can add more fields to the metadata struct without a breaking change in the future.

Links to any relevant issues

part of #1103

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

cargo clippy

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@PhilippGackstatter PhilippGackstatter added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jul 11, 2023
@PhilippGackstatter PhilippGackstatter added this to the v0.7 Features milestone Jul 11, 2023
@PhilippGackstatter PhilippGackstatter merged commit 5eabeff into main Jul 17, 2023
@PhilippGackstatter PhilippGackstatter deleted the chore/polish-identity-iota-core branch July 17, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

Successfully merging this pull request may close these issues.

2 participants