Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Wasm bindings #1206

Merged
merged 13 commits into from
Jul 27, 2023
Merged

Polish Wasm bindings #1206

merged 13 commits into from
Jul 27, 2023

Conversation

PhilippGackstatter
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter commented Jul 17, 2023

Description of change

Polish Wasm bindings by

  • Making all option types consistently use new ...Options() instead of Options.default().
  • Replacing Class with {@link Class} in the docs.
  • Removing the old crypto module that was deactivated, but the files were still there, same with account.

Links to any relevant issues

part of #1103

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

npm run test

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@PhilippGackstatter PhilippGackstatter added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog labels Jul 17, 2023
@PhilippGackstatter PhilippGackstatter marked this pull request as ready for review July 20, 2023 12:37
@PhilippGackstatter PhilippGackstatter merged commit c7aedcb into main Jul 27, 2023
16 checks passed
@PhilippGackstatter PhilippGackstatter deleted the feat/polish-wasm-bindings branch July 27, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants