Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect passed branch for Wasm build #1215

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

eike-hass
Copy link
Collaborator

@eike-hass eike-hass commented Aug 7, 2023

Description of change

Use passed branch to build Wasm.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Impossible to test locally, first test will be successful build-and-test run after merge and then a release form a non-main branch.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eike-hass eike-hass added the No changelog Excludes PR from becoming part of any changelog label Aug 7, 2023
@eike-hass eike-hass changed the title respect passed branch for build Respect passed branch for build Aug 7, 2023
@eike-hass eike-hass changed the title Respect passed branch for build Respect passed branch for Wasm build Aug 7, 2023
@eike-hass eike-hass requested a review from abdulmth August 7, 2023 13:14
@eike-hass eike-hass merged commit 52a53d5 into main Aug 7, 2023
5 of 6 checks passed
@eike-hass eike-hass deleted the chore/respect-ref-for-publish branch August 7, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants