Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated EdDSA verifier crate #1238

Merged
merged 11 commits into from
Sep 22, 2023

Conversation

PhilippGackstatter
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter commented Sep 19, 2023

Description of change

Add a dedicated EdDSA verifier crate which contains a single verifier for curve Ed25519 but could be extended non-breakingly to also support Ed448 later. Other verifier crates could be nicely added alongside it.

This PR also makes the validators fully agnostic over the verifier and not rely on the EdDSA JWS Verifier as the default. Previously the verifier was required even when not using it due to how we used generics. That was changed and the validation methods that don't rely on a verifier were moved to "Util" namespaces. The same applies to the Wasm bindings.

Links to any relevant issues

n/a

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Existing tests & clippy.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@PhilippGackstatter PhilippGackstatter added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Sep 19, 2023
@PhilippGackstatter PhilippGackstatter added this to the v0.7 Features milestone Sep 19, 2023
@PhilippGackstatter PhilippGackstatter marked this pull request as ready for review September 19, 2023 16:30
Copy link
Contributor

@abdulmth abdulmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts and some comments.

examples/Cargo.toml Show resolved Hide resolved
examples/Cargo.toml Show resolved Hide resolved
@PhilippGackstatter PhilippGackstatter merged commit 5b9911b into main Sep 22, 2023
11 checks passed
@PhilippGackstatter PhilippGackstatter deleted the chore/identity-eddsa-verifier branch September 22, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

Successfully merging this pull request may close these issues.

3 participants