Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain linkage grpc #1337

Merged
merged 9 commits into from
Mar 22, 2024
Merged

Add domain linkage grpc #1337

merged 9 commits into from
Mar 22, 2024

Conversation

wulfraem
Copy link
Contributor

Description of change

Adds domain linkage validation to gRPC bindings.

Four endpoints are added. Validation can be started from domain or DID, pre-fetched did-configuration.json files can be pased to endpoints on separate endpoints for domain and DID, looling like following:

  • domain_linkage/DomainLinkage.validate_domain
  • domain_linkage/DomainLinkage.validate_domain_against_did_configuration
  • domain_linkage/DomainLinkage.validate_did
  • domain_linkage/DomainLinkage.validate_did_against_did_configurations

Links to any relevant issues

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Added integration tests for domain linkage validation when starting with domain and DID. did-configuration.json files are passed to endpoint in these tests and not fetched from server.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wulfraem wulfraem requested a review from a team as a code owner March 18, 2024 08:43
@wulfraem wulfraem added Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Mar 18, 2024
Copy link
Contributor

@UMR1352 UMR1352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on submitting your very first PR! Very well done!

@UMR1352 UMR1352 merged commit 1ea3fb2 into grpc-bindings Mar 22, 2024
2 of 3 checks passed
@UMR1352 UMR1352 deleted the feat/add-domain-linkage-grpc branch March 22, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants