Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for relative references in core document #1341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wulfraem
Copy link
Contributor

Description of change

Adds support for relative references in CoreDocument for OrderedSet<MethodRef> fields:

  • authentication
  • assertion_method
  • key_agreement
  • capability_delegation
  • capability_invocation

Added a new enum variant MethodRef::RelativeRefer, which holds a full (including the document's id) DIDUrl. id value is inserted during deserialization andomitted during serializtion to keep DIDUrl value valid but serialize back to original value.

Links to any relevant issues

Implements #1072.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

New tests for (de)serialization added, existing tests still work.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wulfraem wulfraem added Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Mar 22, 2024
@wulfraem wulfraem requested a review from a team as a code owner March 22, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant