Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked Verifiable Presentations #1398

Merged
merged 9 commits into from
Sep 5, 2024
Merged

Conversation

daniel-mader
Copy link
Collaborator

Description of change

Adds support for Linked Verifiable Presentations following this DIF specification.
Implementation follows the existing linked_domain_service.rs.

Links to any relevant issues

n/a

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

  • automated unit tests
  • manual exploration testing

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniel-mader daniel-mader added Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Aug 26, 2024
@eike-hass eike-hass requested a review from UMR1352 August 27, 2024 08:31
@UMR1352
Copy link
Contributor

UMR1352 commented Aug 28, 2024

Hi @daniel-mader, thanks for submitting this. @eike-hass told me you had some concerns regarding the resolution of LinkedVerifiablePresentations as well as the development of WASM bindings for this feature.

As we have done in other instances, we won't provide direct support for resolving LinkedVerifiablePresentations unless hosted on the Tangle (which we don't support yet but we might in the future). Users though should still be able to resolve them manually.

For the latter matter, we will take care of the bindings as well as making sure CI won't complain about the code before merging it.

@UMR1352 UMR1352 marked this pull request as ready for review August 28, 2024 14:56
@UMR1352 UMR1352 requested a review from a team as a code owner August 28, 2024 14:56
@daniel-mader
Copy link
Collaborator Author

Hey @UMR1352, thanks for your feedback! Regarding the resolution, my questions revolve around whether we should check if the link is valid at all or if we should completely treat it as some arbitrary URL and not even check if the resource can be fetched or not. Shall I also guide the user how to create a VP (without nonce) to be hosted or rather add a reference to the existing example?

@UMR1352
Copy link
Contributor

UMR1352 commented Aug 28, 2024

Checking if the URL are fetchable would require resolution of the resource. I think we could simply stick to checking for its syntactic validity.
If you feel like expanding the example that would be great but it's not strictly necessary for the approval of this PR.

@UMR1352 UMR1352 requested a review from wulfraem August 30, 2024 12:27
@daniel-mader daniel-mader force-pushed the feat/linked-verifiable-presentation branch from 5d454c8 to e220db2 Compare August 30, 2024 16:43
@UMR1352 UMR1352 added the Wasm Related to Wasm bindings. Becomes part of the Wasm changelog label Sep 1, 2024
@UMR1352 UMR1352 merged commit deecc7e into main Sep 5, 2024
15 checks passed
@UMR1352 UMR1352 deleted the feat/linked-verifiable-presentation branch September 5, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants