Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for did:jwk resolution #1404

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Add support for did:jwk resolution #1404

merged 7 commits into from
Sep 5, 2024

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Aug 30, 2024 •
edited
Loading

Description of change

Add support for handling and resolving did:jwk DIDs.
WASM bindings included.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

e2e and unit tests.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@UMR1352 UMR1352 added Enhancement New feature or improvement to an existing feature Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Aug 30, 2024
@UMR1352 UMR1352 self-assigned this Aug 30, 2024
@UMR1352 UMR1352 requested a review from a team as a code owner August 30, 2024 13:50
@UMR1352 UMR1352 marked this pull request as draft August 30, 2024 13:54
@UMR1352 UMR1352 added the Wasm Related to Wasm bindings. Becomes part of the Wasm changelog label Aug 30, 2024
@UMR1352 UMR1352 marked this pull request as ready for review August 30, 2024 14:57
wulfraem
wulfraem requested changes Sep 3, 2024
View reviewed changes
bindings/wasm/src/did/did_jwk.rs Show resolved Hide resolved
identity_did/src/did_jwk.rs Outdated Show resolved Hide resolved
identity_did/src/did_jwk.rs Outdated Show resolved Hide resolved
UMR1352 and others added 2 commits September 4, 2024 09:10
@UMR1352 @wulfraem
Update identity_did/src/did_jwk.rs
ebd6e44 
Co-authored-by: wulfraem <wulfraem@users.noreply.github.com>
@UMR1352 @wulfraem
Update identity_did/src/did_jwk.rs
7459f8f 
Co-authored-by: wulfraem <wulfraem@users.noreply.github.com>
@UMR1352 UMR1352 merged commit 02a0857 into main Sep 5, 2024
15 checks passed
@UMR1352 UMR1352 deleted the feat/did-jwk branch September 5, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wulfraem wulfraem wulfraem approved these changes

@itsyaasir itsyaasir itsyaasir approved these changes

Assignees

@UMR1352 UMR1352

Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Enhancement New feature or improvement to an existing feature Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UMR1352 @wulfraem @itsyaasir