Change IotaDocument::verify_document
from a static function to a method
#675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes the static associated function
IotaDocument::verify_document(signed: &IotaDocument, signer: &IotaDocument)
to be a method onIotaDocument
, as suggested in #674. This change is to prevent confusion on the order of parameters in the function signature, as confusingsigned
withsigner
could lead to hard-to-detect bugs.New signature:
IotaDocument::verify_document(&self, signed: &IotaDocument)
This change also applies to
WasmDocument
.This PR also changes the default build target for the
bindings/wasm
project towasm32-unknown-unknown
to ease local development friction when runningcargo
commands following the fixes in PR #666 (thanks @olivereanderson!).Type of change
How the change has been tested
Existing tests and examples which use
verifyDocument
explicitly and implicitly during DID Document resolution pass locally.Change checklist