-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generify Account::client
over Rc
, Arc
#707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cycraig
added
Added
A new feature that requires a minor release. Part of "Added" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
labels
Mar 12, 2022
cycraig
force-pushed
the
feat/account-shared-ptr
branch
from
March 12, 2022 12:53
fc54053
to
b1b843b
Compare
Windows build-and-test job fails due to |
PhilippGackstatter
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
…edger/identity.rs into feat/account-shared-ptr
HenriqueNogara
approved these changes
Mar 14, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This changes the
Account
and its related structs to be generic overArc<Client>
andRc<Client>
so that we can useWasmClient
directly without needing to clone the internalClient
.Unfortunately, to make a long story short: we cannot implement a higher kinded type for
Arc
/Rc
over unsized types, namelydyn Storage
in theAccount
, due to the lack ofCoerceUnsized
in stable Rust.I believe that without implementing
CoerceUnsized
for whateverSharedPtrUnsized
trait we come up with, we will be unable to circumvent the type-mismatch error when trying to pass a concrete instance likeArc<MemStore>
.Example:
The
archery
crate also suffers from this limitation. There is no indication thatCoerceUnsized
will be stabilized any time soon.https://stackoverflow.com/questions/69500407/trait-object-causing-type-mismatch
https://doc.rust-lang.org/std/ops/trait.CoerceUnsized.html
Given the above, I chose to implement the same "poor-man's higher kinded type" approach I used for the
Resolver
in #594, which only works forArc<Client>
/Rc<Client>
due to the same issue.Type of change
How the change has been tested
Tests and examples pass locally.
Change checklist