Improve attach_ and detach_method_relationships in wasm bindings
#775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
added
Wasm
10 tasks
cycraig
reviewed
Mar 29, 2022
Comment on lines
+49
to
+52
| account | ||
| .borrow_mut() | ||
| .update_identity() | ||
| .attach_method_relationship() |
There was a problem hiding this comment.
The Rust name is still singular, do we want to keep it that way or switch to attach/detach_method_relationships? Probably fine either way.
There was a problem hiding this comment.
Since the singular methods are still available, I just left it as is.
cycraig
approved these changes
Mar 29, 2022
abdulmth
changed the title
attach_ and detach_method_relationships in wasm bindingsattach_ and detach_method_relationships in wasm bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Use the
attach_method_relationshipsinstead ofattach_method_relationship, in the wasm bindings. The same fordetach_method_relationship.The original issue #654 included pluralizing the method name, but it turned out that the current implementation already includes both forms,
attach_method_relationshipsandattach_method_relationship(The same fordetach).Links to any relevant issues
fixes issue #654
Type of change
Add an
xto the boxes that are relevant to your changes.