-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wasm Proof
, rename Signature
structs to Proof
#776
Conversation
Signature
structs to Proof
Proof
, rename Signature
structs to Proof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just wondering if renaming GetSignature
to GetProof
makes sense, same for GetSignatureMut
I'm not too fussed on leaving those as |
…feat/wasm-proof
Description of change
Renames
Signature
,SignatureValue
, andSignatureOptions
toProof
,ProofValue
andProofOptions
respectively. This is to avoid duplicateSignature
definitions conflicting in the Wasm bindings.Also adds Wasm bindings for
Proof
to avoid returning theany
type inWasmDocument
andWasmDiffMessage
. Also changes the type ofproperties
inCreateServiceOptions
to avoidany
.Added
WasmProof
.Changed
WasmDocument.proof()
return fromany
toWasmProof
.WasmDiffMessage.proof()
return fromany
toWasmProof
.Signature
toProof
.SignatureValue
toProofValue
.SignatureOptions
toProofOptions
.TrySignature
toGetSignature
.TrySignatureMut
toGetSignatureMut
.Removed
TrySignature::try_signature
.TrySignatureMut::try_signature_mut
.Type of change
How the change has been tested
Wasm tests and examples pass locally.
Change checklist