Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused resolution code #862

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Remove unused resolution code #862

merged 1 commit into from
Jun 3, 2022

Conversation

cycraig
Copy link
Contributor

@cycraig cycraig commented May 31, 2022

Description of change

Removes obsolete, unused code and error variants related to universal resolver functionality. This was unmaintained and not ported to the bindings and so has little effect on users.

Removed

  • Remove Dereference.
  • Remove DocumentMetadata.
  • Remove InputMetadata.
  • Remove Resolution.
  • Remove ResolutionMetadata.
  • Remove ErrorKind.
  • Remove Resource.
  • Remove PrimaryResource.
  • Remove SecondaryResource.
  • Remove MetaDocument.
  • Remove ResolverMethod.
  • Remove resolve.
  • Remove dereference.

Links to any relevant issues

Fixes #532.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tests and examples pass locally. Nothing used this code.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cycraig cycraig added Rust Related to the core Rust code. Becomes part of the Rust changelog. Removed Feature removal that requires a major release. Part of "Removed" section in changelog labels May 31, 2022
@cycraig cycraig added this to the v0.6 Features milestone May 31, 2022
@cycraig cycraig removed this from the v0.6 Features milestone Jun 2, 2022
Copy link
Contributor

@olivereanderson olivereanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cycraig cycraig merged commit fb1948a into dev Jun 3, 2022
@cycraig cycraig deleted the chore/remove-resolution branch June 3, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removed Feature removal that requires a major release. Part of "Removed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Remove old resolution module
3 participants