Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DIDUrl::join to borrow self #871

Merged
merged 4 commits into from
Jun 9, 2022
Merged

Change DIDUrl::join to borrow self #871

merged 4 commits into from
Jun 9, 2022

Conversation

cycraig
Copy link
Contributor

@cycraig cycraig commented Jun 8, 2022

Description of change

Changes DIDUrl::join to borrow self instead of consuming it, as discussed in #805.

Technically a breaking change since explicit functions calls with e.g. DIDUrl::join(url, "blah") would need to change to e.g. DIDUrl::join(&url, "blah").

Links to any relevant issues

See discussion #805.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Minor change, existing unit tests cover it.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cycraig cycraig added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jun 8, 2022
@cycraig cycraig added this to the v0.6 Features milestone Jun 8, 2022
Copy link
Contributor

@olivereanderson olivereanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cycraig cycraig merged commit 955fb16 into dev Jun 9, 2022
@cycraig cycraig deleted the feat/did-url-join-borrow branch June 9, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

Successfully merging this pull request may close these issues.

2 participants