Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api)!: add payload type to block_by_milestone #1116

Merged
merged 5 commits into from
Feb 15, 2023

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Feb 9, 2023

Linked Issues

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

API Changes

  • Test the API endpoints which were added/changed.
  • Ensure that the API response times scale with database size appropriately.
  • Review the API documentation changes and confirm that it matches the actual functionality.
  • Check for breaking changes in the API and matching (conventional) commit message prefix.

Database Changes

  • Review database queries for correctness/conciseness.

@grtlr grtlr marked this pull request as ready for review February 9, 2023 15:06
@DaughterOfMars
Copy link
Collaborator

Doesn't this go against the API spec?

@grtlr
Copy link
Contributor Author

grtlr commented Feb 9, 2023

It does, we have to adapt the spec. But I wanted to get opinions first before I change the Swagger file.

@Alex6323 Alex6323 merged commit d5b9f55 into main Feb 15, 2023
@Alex6323 Alex6323 deleted the feat/api/payload-type branch February 15, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the Block payload type in the Milestone Blocks endpoint
3 participants