feat(api): add JWT authentication #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 26, 2022 08:25
…th to api endpoints and move login to base uri. Fix login info json. Add exp claim to provided jwt.
Alex6323
reviewed
May 27, 2022
pvdrz
approved these changes
Jun 2, 2022
Alex6323
approved these changes
Jun 3, 2022
grtlr
pushed a commit
to grtlr/inx-chronicle
that referenced
this pull request
Jun 10, 2022
* Initial jwt attempt * Better error handling. Correct casing for bearer token. Only apply auth to api endpoints and move login to base uri. Fix login info json. Add exp claim to provided jwt. * Sort * fix feature gating * config jwt expiration * Accept passwords for login instead of hash and configure salt * Add hex dep to api feature * Remove unnecessary clippy tag * Little cleanup to login route
grtlr
pushed a commit
that referenced
this pull request
Jun 22, 2022
* feat(api): add JWT authentication (#205) * Initial jwt attempt * Better error handling. Correct casing for bearer token. Only apply auth to api endpoints and move login to base uri. Fix login info json. Add exp claim to provided jwt. * Sort * fix feature gating * config jwt expiration * Accept passwords for login instead of hash and configure salt * Add hex dep to api feature * Remove unnecessary clippy tag * Little cleanup to login route * PR suggestions * Use updated auth-helper * PR suggestions * PR suggestions * Clean up allow origins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to handle password stuff. I figure the front end should hash it before sending over http, but this is a weak area for me.