Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): add some basic db tests #567

Merged
merged 25 commits into from
Aug 30, 2022
Merged

feat(db): add some basic db tests #567

merged 25 commits into from
Aug 30, 2022

Conversation

DaughterOfMars
Copy link
Collaborator

@DaughterOfMars DaughterOfMars commented Aug 17, 2022 •
edited by grtlr
Loading

Closes #607.
Closes #614.

@DaughterOfMars DaughterOfMars mentioned this pull request Aug 24, 2022
Closed
@luca-moser luca-moser linked an issue Aug 29, 2022 that may be closed by this pull request
Add db tests #607
Closed
grtlr
grtlr reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@grtlr grtlr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the formatting of the Cargo.toml files to single line dependencies.

Also the tests should not live in /src but rather in a top-level folder like integration_tests or just tests.

@grtlr
Copy link
Contributor

grtlr commented Aug 30, 2022

Can you please also ensure that the coverage.yml CI workflow picks up these tests? I'd imagine we'd have to update the script in .github/workflows/scripts/coverage.sh.

@DaughterOfMars
Copy link
Collaborator Author

Can you please also ensure that the coverage.yml CI workflow picks up these tests? I'd imagine we'd have to update the script in .github/workflows/scripts/coverage.sh.

Actually, since that uses cargo test --all it should already pick up the new crate in the workspace.

@grtlr
Copy link
Contributor

grtlr commented Aug 30, 2022

You're right, they are run already

grtlr
grtlr reviewed Aug 30, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
grtlr
grtlr reviewed Aug 30, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@grtlr grtlr merged commit 68d03af into main Aug 30, 2022
@grtlr grtlr deleted the feat/test/add-db-tests branch August 30, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtlr grtlr grtlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent CI from running twice for pull_request and push Add db tests
2 participants
@DaughterOfMars @grtlr