Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stronghold migration #456

Merged
merged 60 commits into from
May 29, 2023
Merged

Stronghold migration #456

merged 60 commits into from
May 29, 2023

Conversation

thibault-martinez
Copy link
Member

No description provided.

thibault-martinez and others added 21 commits March 31, 2023 12:06
@thibault-martinez
Add stronghold v3 migration
5bd6746
@thibault-martinez
Add wallet part
4b3a869
@thibault-martinez @Thoralf-M
Update sdk/src/client/stronghold/migration.rs
8a43e32 
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
@Thoralf-M
Add migration to cli
3cacd1a
@Thoralf-M
Undo change
bd58cc7
@Thoralf-M
Update example
5eec5b5
@Thoralf-M
Address review comments, add more zeroize to password
1533d69
@thibault-martinez
Merge pull request iotaledger#2 from thibault-martinez/stronghold-fix…
76ffece 
…-cli

Add migration to cli
@thibault-martinez
Return StrongholdInvalidPassword
0d57c26
@thibault-martinez
Merge branch 'develop' into stronghold-fix
1a4724a
@thibault-martinez
Merge conflicts
d9ed6be
@thibault-martinez
Fix test
91aa7e4
@thibault-martinez
Merge branch 'develop' into stronghold-fix
814bcc2
@thibault-martinez
Fixes
731c2d7
@thibault-martinez
Use re-exported engine
ba83fb1
@thibault-martinez
Fix migration with data test
924c8e1
@thibault-martinez
Avoid potential migration filename clash
5317a49
@thibault-martinez
Merge branch 'develop' into stronghold-fix
9f2f70c
@thibault-martinez
Clean tests
5ebef99
@thibault-martinez
Expose salt and rounds
b03ffea
@thibault-martinez
Merge branch 'develop' into stronghold-fix
96db11c
@thibault-martinez thibault-martinez marked this pull request as ready for review May 17, 2023 14:56
Alex6323
Alex6323 reviewed May 17, 2023
View reviewed changes
cli/src/command/wallet.rs Outdated Show resolved Hide resolved
DaughterOfMars
DaughterOfMars previously approved these changes May 26, 2023
View reviewed changes
Thoralf-M
Thoralf-M requested changes May 26, 2023
View reviewed changes
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump the versions here to 0.2.86

iota-sdk/.github/workflows/bindings-wasm.yml

Line 68 in a9bb888

version: "0.2.84"

iota-sdk/.github/workflows/bindings-wasm-publish.yml

Line 30 in 3e289c6

version: "0.2.84"

DaughterOfMars
DaughterOfMars previously approved these changes May 26, 2023
View reviewed changes
DaughterOfMars
DaughterOfMars previously approved these changes May 26, 2023
View reviewed changes
@thibault-martinez thibault-martinez merged commit 1540e45 into iotaledger:develop May 29, 2023
@thibault-martinez thibault-martinez deleted the stronghold-migration branch May 29, 2023 10:56
@qrayven qrayven mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex6323 Alex6323 Alex6323 left review comments

@kwek20 kwek20 kwek20 approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thibault-martinez @kwek20 @DaughterOfMars @Alex6323 @Thoralf-M