-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of filters in custom search modal. #1560
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Vivek Jain <vkj.vivekkumarjain@gmail.com>
Signed-off-by: Vivek Jain <vkj.vivekkumarjain@gmail.com>
Signed-off-by: Vivek Jain <vkj.vivekkumarjain@gmail.com>
Just as a consideration, since we already have to change the search component provided by |
d2777e2
to
5cc1abf
Compare
The search query is cleared when the filter is changed in the search modal. This differs from the behavior on the search page, where it just updates the search results. I'd prefer if we can get the search modal to behave the same as the search page. |
This pull request has been deployed to Vercel. Latest commit: 31482b1 ✅ Preview: https://iota-wiki-k32uxfydr-iota1.vercel.app |
@vivekjain23 , could you look into this, please? It's been 2 weeks since this comment |
I have tried to solve it, but my React knowledge is too limited, unfortunately. |
After using the filter for a while, I also think we should make the selection behavior a bit different. Have the "all" filter still select everything, but as soon as you select individual items, I think it is more convenient to clear everything except the one selected item on the first individual selection. Something like: All is selected:
User selects B:
User selects A too:
|
Yupp, thanks for the suggestion. I have implemented it |
This pull request has been deployed to Vercel. Latest commit: fbdf425 ✅ Preview: https://iota-wiki-8qorj3t6g-iota1.vercel.app |
This pull request has been deployed to Vercel. Latest commit: 1ddf1d7 ✅ Preview: https://iota-wiki-77vw3bp9s-iota1.vercel.app |
2b91666
to
ff8d16d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this? I think in most cases the search filter state should revert again 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this tsx? Will make it easier for us to migrate to the new docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you swizzle this in ts please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we automate this somehow? We will never maintain it
Btw there is also still a bug, if there is only 1 search result for example, the footer is not at the bottom of the page |
Description of change
Links to any relevant issues
fixes https://github.com/iotaledger/iota/issues/1438
Type of change
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.